Skip to content

[SYCL] Reorder KernelWrapper::wrap() for kernel functor #19442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Reorder KernelWrapper::wrap() for kernel functor #19442

wants to merge 2 commits into from

Conversation

dyniols
Copy link
Contributor

@dyniols dyniols commented Jul 15, 2025 •
edited
Loading

This PR reorders KernelWrapper::wrap() for kernel functor. The goal is to resolve the issue that occurs when the property modifies the NDRangeDescriptor. In its current state, the kernel functor attempts to modify the NDRangeDescriptor before it has been properly set.

@dyniols dyniols temporarily deployed to WindowsCILock July 15, 2025 09:15 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock July 15, 2025 09:43 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock July 15, 2025 09:43 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock July 15, 2025 11:33 — with GitHub Actions Inactive
@dyniols dyniols changed the title Test [SYCL] Reorder KernelWrapper::wrap() for kernel functor Jul 15, 2025
@dyniols dyniols marked this pull request as ready for review July 15, 2025 11:51
@dyniols dyniols requested a review from a team as a code owner July 15, 2025 11:51
@dyniols dyniols temporarily deployed to WindowsCILock July 15, 2025 12:00 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock July 15, 2025 12:00 — with GitHub Actions Inactive
aelovikov-intel
aelovikov-intel requested changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a functional change and must come with a test. Also, the comments right only hint in the general direction of what is going on but lack details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel requested changes

@againull againull Awaiting requested review from againull againull is a code owner automatically assigned from intel/llvm-reviewers-runtime

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyniols @aelovikov-intel